Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an overload for com.snowflake.snowpark.functions.sum #84

Merged
merged 4 commits into from
Mar 8, 2024
Merged

Create an overload for com.snowflake.snowpark.functions.sum #84

merged 4 commits into from
Mar 8, 2024

Conversation

sfc-gh-aherreraaguilar
Copy link
Contributor

@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar commented Feb 19, 2024 •
edited by jira bot
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes # SCT-2665

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Added an overload for the sum function which supports a string parameter.

Pre-review checklist

(For Snowflake employees)

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-aherreraaguilar
Copy link
Contributor Author

@sfc-gh-bli Thanks, I fixed all the comments, please review again.

sfc-gh-bli
sfc-gh-bli approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@sfc-gh-bli sfc-gh-bli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar merged commit 55aaf09 into main Mar 8, 2024
14 checks passed
@sfc-gh-aherreraaguilar sfc-gh-aherreraaguilar deleted the sct-2665 branch March 8, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez sfc-gh-mvegaalvarez approved these changes

@sfc-gh-bli sfc-gh-bli sfc-gh-bli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aherreraaguilar @sfc-gh-bli @sfc-gh-mvegaalvarez